View previous topic :: View next topic |
Author |
Message |
r00k
Joined: 13 Nov 2004 Posts: 483
|
Posted: Sun Jun 28, 2009 5:49 am Post subject: |
|
|
No this was in reply to the do it by hand route.
This allows you to see ALL of the source code and the DIFF is highlighted for you to read surrounding code to help understand what its doing  |
|
Back to top |
|
 |
goldenboy

Joined: 05 Sep 2008 Posts: 310 Location: Kiel
|
Posted: Mon Jun 29, 2009 4:41 pm Post subject: |
|
|
It's good to have an example implementation. A step in the right direction.
However, plain diff and applying the patch to something like Fitz or Tyrquake probably won't work because most engines are quite different from Winquake today.
Manual fixing will be required. Since it's a big patch, you might just grow grey hair about it. Ideally, engine coders would add it to their engines, a change which might be work intensive, but only needs to be done once. In theory.
In practice, it would be nice if Spike just declared this some sort of standard, so engine coders could say "supports CSQC version blah" and mappers/modders would have something "hard" to target.
We don't need to hope for a FTE/darkplaces common standard, so I'd say Spike should just go ahead with this. If I'm not mistaken, he's "the csqc guy" and he provided the example implementation, so he should just do it. A standard is needed. I think anyone with some sense should probably use/implement the FTE version of csqc.
In principle, building a diff and then applying it (partly by hand) should work of course.
Go csqc!
 |
|
Back to top |
|
 |
mh

Joined: 12 Jan 2008 Posts: 910
|
Posted: Mon Jun 29, 2009 5:19 pm Post subject: |
|
|
The way I intend exploring it is by using a graphical diff tool against a stock ID sourcebase that will let me see the precise lines of code that have been changed, then making a call on whether or not the payback will be worth the effort. CSQC has been on my "nice to have" list for a while, but I don't really see it as a make or break feature just yet (maybe if more mods used it, which hopefully this release will encourage). _________________ DirectQ Engine - New release 1.8.666a, 9th August 2010
MHQuake Blog (General)
Direct3D 8 Quake Engines |
|
Back to top |
|
 |
Spike
Joined: 05 Nov 2004 Posts: 944 Location: UK
|
Posted: Mon Jun 29, 2009 7:48 pm Post subject: |
|
|
Personally I'm the sort of person that likes to merge stuff by hand.
If its someone submitting a patch for one of my bugs, I like to know where I fecked up.
That patch is incomplete (hence why it wasn't me that posted a link to it). I think the listener properties arn't implemented (so you can't move/rotate the camera too far). Project/Unproject are not implemented, so you can't use mouse cursors. You should be able to use picture-in-picture, but water warping is broken/disabled in sw.
2d drawing is somewhat limited. I was working in that area when I got bullied into doing other stuff for my own engine.
When writing that patch, it really occured to me how little I still know about the quirks of the software renderer (hence the water warping). I lost a lot of time on that, and it still doesn't quite work properly.
If someone does notice any undesired changes, please be sure you tell me about them. :)
There are a few comments scattered around the code, FIXMEs and ENGINEDEVS that basically point out locations in the code that enhanced engines probably want to tweek. This patch is otherwise standard quake1.10 and thus does not have stuff like animation blending, so yeah, there is more to it than just merging the diff. While there's no compatibility lost from not doing the final tweeks, it really is missing something. :)
Still, now that it is out in the open, if anyone does wish to offer patches to fix missing features/bugs or just clean up some of the code, patches are welcome - I'll merge them by hand. :) _________________ What's a signature? |
|
Back to top |
|
 |
ceriux

Joined: 06 Sep 2008 Posts: 969 Location: Florida, USA
|
Posted: Mon Jun 29, 2009 8:00 pm Post subject: |
|
|
iv tried engine coding, other wise id take a try at this, but my compiler or w/e wont even compile premade versions of engines... wait wait i got it to compile vannilla once. _________________ QuakeDB - Quake ModDB Group |
|
Back to top |
|
 |
Team Xlink
Joined: 25 Jun 2009 Posts: 320
|
Posted: Wed Jul 01, 2009 4:54 pm Post subject: |
|
|
Spike, I merged it all had by hand. I searched through all of the source files for the csqc and spike and I put them in my engine. It didn't work. I have so many compileing errors. I have been having the hardest time doing this. If I do get this figured out I will definately make a patch but until then I will have to keep trying to get it to work.
After reading your post that the WinQuake CSQC was not finished. I may just go port it to my engine from DarkPlace's Source or the FTE's source. I am wondering if there is an easier way to port the code over. If I do get it figuredout, I will make a tutorial on it so that it can be done easier. I hope I will get it to work. _________________
Anonymous wrote: | if it works, it works. if it doesn't, HAHAHA! |
Last edited by Team Xlink on Wed Jul 01, 2009 4:58 pm; edited 1 time in total |
|
Back to top |
|
 |
Urre

Joined: 05 Nov 2004 Posts: 1073 Location: Sweden
|
Posted: Wed Jul 01, 2009 4:58 pm Post subject: |
|
|
This thread rules. Hope more engine-devs begin adopting this monster of a feature _________________ Look out for Twigboy |
|
Back to top |
|
 |
Team Xlink
Joined: 25 Jun 2009 Posts: 320
|
Posted: Wed Jul 01, 2009 5:07 pm Post subject: |
|
|
Spike, I think I have thought of an easy way to find out the csqc changes.
Do you have your engines source for the first version with csqc and then the one before it that didn't have csqc? _________________
Anonymous wrote: | if it works, it works. if it doesn't, HAHAHA! |
|
|
Back to top |
|
 |
Spirit

Joined: 20 Nov 2004 Posts: 476
|
Posted: Wed Jul 01, 2009 8:20 pm Post subject: |
|
|
Just get id Software's original source release of it. _________________ Quake Maps |
|
Back to top |
|
 |
Team Xlink
Joined: 25 Jun 2009 Posts: 320
|
Posted: Sun Jul 12, 2009 8:40 pm Post subject: |
|
|
No, I want to see what changes were made. If I compare the one without CSQC to the next version right after with CSQC it will point out all of the differences needed. _________________
Anonymous wrote: | if it works, it works. if it doesn't, HAHAHA! |
|
|
Back to top |
|
 |
Spike
Joined: 05 Nov 2004 Posts: 944 Location: UK
|
Posted: Sun Jul 12, 2009 10:09 pm Post subject: |
|
|
The *only* changes to that version of winquake are the addition of csqc. That was the whole point of making that version.
There are quite a few changes needed for csqc. All over the place. That version doesn't even consider the sound changes. _________________ What's a signature? |
|
Back to top |
|
 |
Downsider

Joined: 16 Sep 2008 Posts: 478
|
Posted: Mon Jul 13, 2009 4:15 am Post subject: |
|
|
Compare ID's official release of WinQuake to WinQuake with CSQC and look at the differences. The rest is obvious.
Just wondering, how updated IS this WinQuake w/CSQC deal? What features are omitted, and what is there? |
|
Back to top |
|
 |
Baker

Joined: 14 Mar 2006 Posts: 1538
|
Posted: Mon Aug 10, 2009 11:16 am Post subject: |
|
|
Team Xlink wrote: | No, I want to see what changes were made. If I compare the one without CSQC to the next version right after with CSQC it will point out all of the differences needed. |
You need WinMerge, sir.
Makes life easy.
http://winmerge.org/
Free, open source and is awesome. There may be slightly better tools that are commercial (like ExamDiff), but WinMerge is far more than adequate and very great. _________________ Tomorrow Never Dies. I feel this Tomorrow knocking on the door ... |
|
Back to top |
|
 |
Downsider

Joined: 16 Sep 2008 Posts: 478
|
Posted: Mon Aug 10, 2009 12:20 pm Post subject: |
|
|
Well it's a month after and I believe that's already been said, too. Anyway, if this is for Solitude, why don't you do it, who's far more experienced? |
|
Back to top |
|
 |
Team Xlink
Joined: 25 Jun 2009 Posts: 320
|
Posted: Wed Aug 12, 2009 9:39 pm Post subject: Status Report |
|
|
Well, I just finished doing all of the common files, (the ones that can be winmerged) so I am about 80% done. _________________
Anonymous wrote: | if it works, it works. if it doesn't, HAHAHA! |
|
|
Back to top |
|
 |
|