May have found a bug in this code; see here: http://www.celephais.net/board/view_thr ... &start=147
Disabling the rotation stuff in world.c fixes it, but obviously that's not 100% desirable for various reasons.
Avirox's Rotation Tutorial Adapted to NetQuake
Moderator: InsideQC Admins
A small optimization...
by taniwha » Tue Dec 14, 2010 12:39 am
Leave others their otherness.
http://quakeforge.net/
http://quakeforge.net/
- taniwha
- Posts: 399
- Joined: Thu Jan 14, 2010 7:11 am
by mh » Sun Apr 10, 2011 2:05 pm
More info again.
In the particular case I've found, the brush is incorrectly offset from it's bounding box in most engines. I've tested in Fitz, DP, RMQ, DirectQ, ProQuake, Qrack, TyrQuake. Here's a shot from Fitz illustrating the problem.
Oddly enough ProQuake and TyrQuake are the only ones from my list that get it right. I say "oddly" because ProQuake - I assume - has server-side rotation support (unless Baker never got round to putting it in). I also say "oddly" because Fitz doesn't.
I was working on the basis that the root cause was rotation support, particularly in light of the fact that a reversion of one part of this code to the #ifdef'ed out ID original fixes another bug - the brush not coming up.
The next step I think is to start reverting portions of code back to the original and see if I can identify at which point it breaks. More later.
In the particular case I've found, the brush is incorrectly offset from it's bounding box in most engines. I've tested in Fitz, DP, RMQ, DirectQ, ProQuake, Qrack, TyrQuake. Here's a shot from Fitz illustrating the problem.
Oddly enough ProQuake and TyrQuake are the only ones from my list that get it right. I say "oddly" because ProQuake - I assume - has server-side rotation support (unless Baker never got round to putting it in). I also say "oddly" because Fitz doesn't.
I was working on the basis that the root cause was rotation support, particularly in light of the fact that a reversion of one part of this code to the #ifdef'ed out ID original fixes another bug - the brush not coming up.
The next step I think is to start reverting portions of code back to the original and see if I can identify at which point it breaks. More later.
-
mh - Posts: 2292
- Joined: Sat Jan 12, 2008 1:38 am
Inquisitive minds want to know ! And if they don't -- well like that ever has stopped me before ..
by mh » Sun Apr 10, 2011 8:55 pm
In the specific map that brought it to my attention the brush model in question actually did have an angles of (0, -1, 0) in the BSP file. No amount of anything on the server is going to fix that, and the bug did definitively manifest as a direct result of rounding. Don't round - no bug. Round to nearest - bug.
It also manifested in an engine that does not support rotation, but that does use rounding - FitzQuake. It can be reproduced in stock ID Quake (or any other engine that does not support rotation) simply by adding rounding.
I've nothing against rounding - this is clearly a map/editor/tool bug (the worldmodel itself had angles of (0, -92, 0)!!!) rather than an engine bug. But it poses the interesting question: if it worked in ID Quake, but yet is clearly a content bug (in other words it worked by accident rather than by design), should it be "fixed"?
It also manifested in an engine that does not support rotation, but that does use rounding - FitzQuake. It can be reproduced in stock ID Quake (or any other engine that does not support rotation) simply by adding rounding.
I've nothing against rounding - this is clearly a map/editor/tool bug (the worldmodel itself had angles of (0, -92, 0)!!!) rather than an engine bug. But it poses the interesting question: if it worked in ID Quake, but yet is clearly a content bug (in other words it worked by accident rather than by design), should it be "fixed"?
-
mh - Posts: 2292
- Joined: Sat Jan 12, 2008 1:38 am
Return to Programming Tutorials
Who is online
Users browsing this forum: No registered users and 1 guest