Bug fix - noclip touching triggers

[mh]

[taniwha]

Nice, that one has been bugging me for a long time (but never enough to do anything about it). However, why not SV_LinkEdict (ent, ent->v.movetype != MOVETYPE_NOCLIP)? A good compiler will do the same thing (I've seen gcc do it), but I feel the one call is clearer than two separate calls. Can even do SV_LinkEdict (ent, !developer.value || ent->v.movetype != MOVETYPE_NOCLIP).

I think this is one of those things that id never fixed due to lack of time and pressing need, rather than intended design.

ps, I prefer to use "if" to select different code paths rather than simple parameter values (unless things start getting too messy, then I'll use an "if"). Also, if you prefer to keep the ==, use !(ent->v.movetype == MOVETYPE_NOCLIP).

[r00k]

[mh]

[taniwha]

Indeed, it is more just style, and if/else does have its advantages, too. I was just curious.

Ah, yeah. grey does look a bit better than black.

What about fog? The noclip world looks a little odd when fog is enabled.

[Baker]

Does this make it so you don't grab weapons and health boxes?

[Is the noclip movetype ever actually used in a mod? ]

[taniwha]

Baker: indeed it does.

[mh]

Grey is better I think cos it's easier to see things when noclipping - with black a lot of detail gets lost (especially if lighting is dark).

Not too concerned about fog to be honest; I don't see this as a mode where correctness is important. All the same - turn off fog when viewleaf is CONTENTS_SOLID maybe? Given that the main purpose of noclipping out of a map is to see things, that seems to make sense.

And yeah, you won't pick up stuff either.